Add support for SqlConnectionOverrides for OpenAsync() API #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
benrr101,
David-Engel,
JRahnama and
DavoudEshtehari
cheenamalhotra
added
the
🆕 Public API
| ..\doc\snippets\Microsoft.Data.Sql\SqlDataSourceEnumerator.xml = ..\doc\snippets\Microsoft.Data.Sql\SqlDataSourceEnumerator.xml | ||
| ..\doc\snippets\Microsoft.Data.Sql\SqlNotificationRequest.xml = ..\doc\snippets\Microsoft.Data.Sql\SqlNotificationRequest.xml |
There was a problem hiding this comment.
Could you revert the irrelevant changes in the solution file, please?
| { | ||
| SqlConnectionStringBuilder connectionStringBuilder = new(DataTestUtility.TCPConnectionString) | ||
| { | ||
| InitialCatalog = "DoesNotExist0982532435423", |
There was a problem hiding this comment.
It's less likely to exist.
Suggested change
| InitialCatalog = "DoesNotExist0982532435423", | |
| InitialCatalog = DataTestUtility.GetUniqueNameForSqlServer("DoesNotExist", false), |
| await Assert.ThrowsAsync<SqlException>(async () => await sqlConnection.OpenAsync(CancellationToken.None)); | ||
| timer.Stop(); | ||
| duration = timer.Elapsed; | ||
| Assert.True(duration.Seconds > 5, $"Connection OpenAsync() with retries took less time than expected. Expect > 5 sec with transient fault handling. Took {duration.Seconds} sec."); // sqlConnection.OpenAsync(); |
There was a problem hiding this comment.
Suggested change
| Assert.True(duration.Seconds > 5, $"Connection OpenAsync() with retries took less time than expected. Expect > 5 sec with transient fault handling. Took {duration.Seconds} sec."); // sqlConnection.OpenAsync(); | |
| Assert.True(duration.Seconds > 5, $"Connection OpenAsync() with retries took less time than expected. Expect > 5 sec with transient fault handling. Took {duration.Seconds} sec."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name suggests, introduces new API:
Previously, we skipped addiing overrides to OpenAsync in PR #463 due to no transient fault handling, but with recent PR #1983 we now enable transient fault handling by default for
OpenAsync()too.To support fail fast behavior in OpenAsync(), we need to allow passing
SqlConnectionOverridesinOpenAsync()too.Additional context:
dotnet/efcore#33399
#29