-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes FormatException when Tracing is enabled #1291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Perhaps there need to be some tests run with tracing enabled. |
The use case is related to refreshing access token before expiry which will be a long wait in test suite. |
Ok, making the tests take even longer isn't a good idea. |
@JRahnama can you port this fix to 3.1-servicing so we could potentially pick it up if there's another SSMS 19.x release? |
@shueybubbles I will add this to our list. |
This is a fix for the bug #1290 by simply removing the redundant argument from the overload.