Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .NET Core 2.1 (now Out of Support) #1272

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Sep 22, 2021

.NET Core 2.1 End of life

.NET Core 2.1 reached end of life in August 2021. Microsoft.Data.SqlClient v4.0 drops dedicated support for .NET Core 2.1, and fallbacks to .NET Standard 2.0 for consuming applications. Customers are recommended to migrate their apps to use supported versions of .NET Core 3.1+.

Reference: .NET Support Policy

@cheenamalhotra cheenamalhotra added the 🔨 Breaking Change Use this label for breaking API changes in the driver. label Sep 22, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview3 milestone Sep 22, 2021
@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v4.0 via automation Sep 22, 2021
Copy link
Contributor

@lcheunglci lcheunglci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JRahnama
Copy link
Member

LGTM.

NIT: There are a couple of places that needs to be considered if we want to take those mentioned netcore2.1 out:

  1. SNIStream.cs line 10 in the comments
  2. SqlClientEventSource line 22 in the #region

SqlClient v4.0 automation moved this from In progress to Reviewer approved Sep 28, 2021
@cheenamalhotra cheenamalhotra merged commit e66e1b9 into dotnet:main Sep 28, 2021
SqlClient v4.0 automation moved this from Reviewer approved to Done Sep 28, 2021
@cheenamalhotra cheenamalhotra deleted the drop-netcore2.1 branch September 30, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Breaking Change Use this label for breaking API changes in the driver.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants