Include BCL assemblies required for VS 2017 build tools #590
Conversation
|
@KalleOlaviNiemitalo could you please verify that this addresses the problem? You can download the package built by this PR for testing from the |
|
@AArnott thank you. I don't know whether I'll have time to test it today. Before Monday for sure. |
|
I tried testing it myself, but it seems SDK style projects can't build with just the VS 2017 Build Tools installed. I filed a bug against them on that in the meantime. |
|
I found a way to test it. It doesn't work because another assembly is then missing. I'm working on a better fix. |
AArnott
force-pushed
the
fix589
branch
2 times, most recently
from
162443a
to
de7e8b4
Compare
AArnott
changed the title
Several assemblies are required by this msbuild task but are not included in MSBuild 2017. Adding the assemblies to the package alone is not enough, since binding redirects are also missing in msbuild.exe.config. We make up for this with a custom assembly resolver. Fixes #589
|
https://dev.azure.com/andrewarnott/OSS/_build/results?buildId=4555&view=artifacts&pathAsName=false&type=publishedArtifacts (#3.4.196+e22f3b6a14) seems to be the build with the latest changes. |
|
You can get it now per the instructions on the README from our CI feed, if you want it before we push to nuget.org. |
Include BCL assemblies required for VS 2017 build tools
Several assemblies are required by this msbuild task but are not included in MSBuild 2017.
Adding the assemblies to the package alone is not enough, since binding redirects are also missing in msbuild.exe.config. We make up for this with a custom assembly resolver.
Fixes #589