pathFilters paths should be relative to the version.json

[saul]

Fixes #451. Path were incorrectly relative to the project directory.

This PR ended up being a bit more an invasive change than I initially anticipated. This is because the JSON serialisation code understandably had no notion of where the version.json was being written to.

Changes

• VersionFile.SetVersion/GetVersion must point to version.json files that reside in a Git repository to be able to serialize/deserialize path filters
• FilterPath is now part of the public API, and is used on the VersionFile class
• Added lots of tests :)

[AArnott]

Thanks so much for fixing this. I see what you mean by it being pretty invasive, but I support what you're doing. Just a few touch-ups and your own TODO comments to resolve and I'll merge.

[AArnott]

Thanks, @saul. This is looking good. But you have evidently introduced a test failure in GetBuildVersion_OutsideGit_PointingToGit. Can you look into that?

[saul]

Unfortunately I can't run those tests, even on master I get:

BuildIntegrationTests.GetBuildVersion_OutsideGit_PointingToGit

System.IO.FileLoadException: The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

System.IO.FileLoadException
The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
   at BuildIntegrationTests.Init()
   at BuildIntegrationTests..ctor(ITestOutputHelper logger) in C:\Code\Nerdbank.GitVersioning\src\NerdBank.GitVersioning.Tests\BuildIntegrationTests.cs:line 55

[AArnott]

OK, I'll look into it then. Thanks.

[AArnott]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).