Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ProjectReference into a conditional import #1043

Closed
wants to merge 1 commit into from
Closed

Move ProjectReference into a conditional import #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Nerdbank.GitVersioning.Tasks/build/MSBuildTargetCaching.targets
View file
Open in desktop
Expand Up @@ -33,15 +33,15 @@
<Visible>false</Visible>
<PrivateAssets>all</PrivateAssets>
</NBGV_CachingProjectReference>

<!-- Declare a P2P so that "msbuild -graph -isolate" doesn't complain when we use the MSBuild task to invoke our inner shared project.
This causes a lot of problems (https://github.com/dotnet/Nerdbank.GitVersioning/issues?q=label%3Amsbuild-p2p+) with projects
that expect to understand all their own ProjectReferences though, so only define it when the user is running a graph build. -->
<ProjectReference Include="@(NBGV_CachingProjectReference)" Condition="'$(IsGraphBuild)'=='true'">
<NBGV_InnerProject>true</NBGV_InnerProject>
</ProjectReference>
</ItemGroup>

<!-- Declare a P2P so that "msbuild -graph -isolate" doesn't complain when we use the MSBuild task to invoke our inner shared project.
This causes a lot of problems (https://github.com/dotnet/Nerdbank.GitVersioning/issues?q=label%3Amsbuild-p2p+) with projects
that expect to understand all their own ProjectReferences though, so only define it when the user is running a graph build.
Rather than condition the item (which the legacy project system 'sees through' using MSBuild APIs),
we condition an import so that the item will be utterly undiscoverable by the project system. -->
<Import Project="ProjectReferenceForGraphBuild.targets" Condition="'$(IsGraphBuild)'=='true'"/>

<Target Name="InvokeGetBuildVersionTask">
<Error Text="BuildMetadata items changed after a copy was made. Add all BuildMetadata items before importing this file." Condition=" '@(BuildMetadata)' != '@(_BuildMetadataSnapped)' " />

Expand Down
7 changes: 7 additions & 0 deletions src/Nerdbank.GitVersioning.Tasks/build/ProjectReferenceForGraphBuild.targets
View file
Open in desktop
@@ -0,0 +1,7 @@
<Project>
<ItemGroup>
<ProjectReference Include="@(NBGV_CachingProjectReference)">
<NBGV_InnerProject>true</NBGV_InnerProject>
</ProjectReference>
</ItemGroup>
</Project>