Merge pull request #581 from dotnet/fix580

Avoid writing garbage bytes to read blobs in managed git engine
dotnet · Apr 7, 2021 · 536c1fd · 536c1fd
2 parents 707e619 + ae45375
commit 536c1fd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/NerdBank.GitVersioning/ManagedGit/GitPackMemoryCacheStream.cs b/src/NerdBank.GitVersioning/ManagedGit/GitPackMemoryCacheStream.cs
@@ -49,9 +49,9 @@ public override int Read(Span<byte> buffer)
             {
                 var currentPosition = this.cacheStream.Position;
                 var toRead = (int)(buffer.Length - this.cacheStream.Length + this.cacheStream.Position);
-                this.stream.Read(buffer.Slice(0, toRead));
+                int actualRead = this.stream.Read(buffer.Slice(0, toRead));
                 this.cacheStream.Seek(0, SeekOrigin.End);
-                this.cacheStream.Write(buffer.Slice(0, toRead));
+                this.cacheStream.Write(buffer.Slice(0, actualRead));
                 this.cacheStream.Seek(currentPosition, SeekOrigin.Begin);
                 this.DisposeStreamIfRead();
             }