fix(#630): Move config values from property directly onto parameters ... #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
kevinboss
changed the title
kevinboss
force-pushed
the
feature/fix-commit-docker-4.19
branch
from
495abce
to
7ffdb07
Compare
kevinboss
force-pushed
the
feature/fix-commit-docker-4.19
branch
from
7ffdb07
to
d35930e
Compare
kevinboss
changed the title
kevinboss
changed the title
There was a problem hiding this comment.
👍 I think that is better, thanks! @galvesribeiro WDYT?
Also note what I found in the latest Moby release notes:
API: Fix an issue where
POST /commitdid not accept an empty request body. moby/moby#45568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630
Ideally the parameter class would be redesigned to look similar to CreateContainerParameters but that would be a breaking change.