Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - incorrect table markdown #2545 #2565

Merged

Conversation

AumkarGorde
Copy link
Contributor

Fix - incorrect table markdown #2545

@timcassell
Copy link
Collaborator

@AumkarGorde Can you please update the MarkdownExporterVerifyTests to make sure the previous behavior breaks the test and your fix passes the test?

@AumkarGorde
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out locally, LGTM. Thanks @AumkarGorde! Will merge after CI passes.

@timcassell timcassell merged commit 205ce61 into dotnet:master Apr 28, 2024
8 checks passed
@timcassell timcassell added this to the v0.14.0 milestone Apr 28, 2024
@timcassell timcassell linked an issue Apr 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HideColumns + custom corerun = incorrect table markdown
2 participants