Initial ScottPlotExporter with just Bar Plot and Unit Tests #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
reviewed
Apr 13, 2024
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Show resolved
Hide resolved
timcassell
reviewed
Apr 13, 2024
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
timcassell
reviewed
Apr 13, 2024
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
|
@dotnet-policy-service agree |
timcassell
reviewed
Apr 14, 2024
src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
Outdated
Show resolved
Hide resolved
timcassell
reviewed
Apr 14, 2024
src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
Outdated
Show resolved
Hide resolved
timcassell
reviewed
Apr 15, 2024
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
timcassell
reviewed
Apr 19, 2024
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
….Exporters.Plotting.Tests.csproj
|
Hey @timcassell and @AndreyAkinshin just checking in for a status update on this one. I'm happy for any feedback. My plan was to add the rest of the charts that the R plot has once this PR was accepted. |
timcassell
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM, but @AndreyAkinshin controls the Nuget packages, so he'll need to approve this and get it on Nuget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new project called BenchmarkDotNet.Exporters.Plotting.
Currently just supports Bar Plots with configurable options for Width, Height and whether to RotateLabels (for large bar labels defaults to true).
Example Bar Plot:
NOTE: Currently build gets an error about strong naming?