New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features Benchmark Snapshot #2147
base: master
Are you sure you want to change the base?
Features Benchmark Snapshot #2147
Conversation
@adamsitnik @AndreyAkinshin do you have any suggestions to improve the quality ad fix issue of this PR? |
1ac2f38
to
d8381b0
Compare
A cmd tool is better suited for this, which merges the results based on the BDN artifact files.
Can you clarify what you mean? |
Looks like you misspelled |
d8381b0
to
da95a0a
Compare
Why? With the approach I suggested, you can have the comparison in all existing exporters using the engine of
In my spare time I am developing a benchmark comparator for avalonia. But maintainers don't want to publish Avalonia.Base.UnitTests as a nuget. |
da95a0a
to
201738e
Compare
src/BenchmarkDotNet.Snapshot/Toolchains/Snapshot/SnpashotBuilder.cs
Outdated
Show resolved
Hide resolved
201738e
to
dda90d8
Compare
f363532
to
4cb7cc1
Compare
What do you think if you base the implementation of this functionality above the PR #2178? |
451debd
to
387c575
Compare
387c575
to
4cad4f1
Compare
8c63284
to
7f77661
Compare
1c2f05e
to
7ab489f
Compare
7ab489f
to
f744f77
Compare
f744f77
to
72e666a
Compare
72e666a
to
3370ce1
Compare
- Source json Snapshot folder is benckmarck path - Output json Snapshot path is ArtifactsPath
3370ce1
to
f793d78
Compare
f71abe0
to
f67f172
Compare
# Conflicts: # BenchmarkDotNet.sln # samples/BenchmarkDotNet.Samples/BenchmarkDotNet.Samples.csproj
This is a preliminary version.
The purpose
The purpose of this PR is to make it possible to compare benchmarks between two versions or run when nuget packages cannot be used.
How works
Use the ability to create custom toolchains to inject ExecuteResults previously saved into a store. To associate methods between two executions, hash of BenchmarkCase.Descriptor. At this time only the json store is implemented.
Pro
Cons
Known Issues
I am unable to obtain the path of artifacts in the Snapshot restore phaseExample of output