Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding columns #1890

Merged
merged 13 commits into from
Aug 25, 2022
Merged

Hiding columns #1890

merged 13 commits into from
Aug 25, 2022

Commits on Jan 29, 2022

  1. Move literals into a class; In future it will be used for cli code co… 

    …mpletion; StatisticalTest/HardwareCounters/CiLower are missing
    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    f3b3a9d View commit details
    Browse the repository at this point in the history

  2. Add HideColumns

    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    dd10a4e View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    4e2568f View commit details
    Browse the repository at this point in the history

  4. Do not start printing a table when no columns, details: 

    When all columns are disabled, it was printing:

|
|
|

Replace it with the message, which is in contrast with errors
    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    71aa462 View commit details
    Browse the repository at this point in the history

  5. Show legends only for visible columns i.e. hide the time legend when … 

    …Mean&Error are hidden
    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    96dd73e View commit details
    Browse the repository at this point in the history

  6. Replace AllocRatio ctor creation to the static field, like BaselineRa… 

    …tioColumn.RatioMean
    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    f66f789 View commit details
    Browse the repository at this point in the history

  7. Empty; merge conflict resolved

    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    549cefc View commit details
    Browse the repository at this point in the history

  8. Encapsulate tight logic in SummaryTableColumn

    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    f2ca9f4 View commit details
    Browse the repository at this point in the history

  9. Add CLI support

    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    728365e View commit details
    Browse the repository at this point in the history

  10. Print common columns when all columns are hidden

    @YegorStepanov
    YegorStepanov committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    82d7b2f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Merge remote-tracking branch 'upstream/master' into hide-columns 

    # Conflicts:
#	src/BenchmarkDotNet/Configs/ManualConfig.cs
#	src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
    @adamsitnik
    adamsitnik committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    560a1b2 View commit details
    Browse the repository at this point in the history

  2. solve warnings and errors

    @adamsitnik
    adamsitnik committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f12cda0 View commit details
    Browse the repository at this point in the history

  3. improvements: 

    - don't store Names in the field when there is no need to
- make it possible to apply `[HideColumnsAttribute]` to entire assembly
- add comment explaining why Column class is public
- make two existing column hiding rules public so they can be reused
- Column.IsCommon is better name than Column.IsCommonColumn
- simplify LINQ
-add sample
    @adamsitnik
    adamsitnik committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    eb59001 View commit details
    Browse the repository at this point in the history