Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of warning #1760

Merged
merged 1 commit into from Jul 30, 2021
Merged

Get rid of warning #1760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/BenchmarkDotNet.IntegrationTests/ThreadingDiagnoserTests.cs
View file
Open in desktop
Expand Up @@ -156,7 +156,7 @@ private void AssertStats(Summary summary, Dictionary<string, (string metricName,
var metric = selectedReport.Metrics.Single(m => m.Key == assertion.Value.metricName);

// precision is set to 2 because CoreCLR might schedule some work item on it's own and hence affect the results..
// precision = 3 is not enough (e.g., sometimes the actual value may be equal 1.0009765625 while the expected value is 1.0)
// precision = 3 is not enough (e.g., sometimes the actual value may be equal 1.0009765625 while the expected value is 1.0)
Assert.Equal(assertion.Value.expectedValue, metric.Value.Value, precision: 2);
}
}
Expand Down