Introduce MockToolchain #2178
Merged
Introduce MockToolchain #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamsitnik what do you think? |
AndreyAkinshin
force-pushed
the
mocktoolchain
branch
from
2d0478d
to
bfb6a30
Compare
AndreyAkinshin
force-pushed
the
mocktoolchain
branch
from
bfb6a30
to
7dd1b1d
Compare
adamsitnik
reviewed
Feb 13, 2023
| { | ||
| public static class MockHelper | ||
| { | ||
| public static Summary Run<T>(ITestOutputHelper output) |
There was a problem hiding this comment.
We could make this method accept a mandatory Func<BenchmarkCase, List<Measurement>> argument, pass it to MockToolchain instance and remove the need of having a custom attribute, interface and reflection.
Sample usage could look like this:
MockHelper.Run<BenchmarkClass>(output, benchmarkCase =>
benchmarkCase.Descriptor.WorkloadMethod.Name switch
{
"Foo" => CreateFromValues(new double[] { 2, 2, 2 }),
"Bar" => CreateFromValues(new double[] { 4, 4, 4 }),
_ => throw new InvalidOperationException()
});There was a problem hiding this comment.
@adamsitnik good idea, I like it! I rewrote the implementation, could you please check out the new version?
AndreyAkinshin
force-pushed
the
mocktoolchain
branch
from
7dd1b1d
to
0a218ec
Compare
|
@adamsitnik I just merged #2268 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new toolchain allows writing simple unit tests for summary tables without a need to actually run benchmarks. The usage of the new API is shown in
RatioColumnTest.