Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update server preset guide to reflect changes in v0.8 #9954

Merged
merged 3 commits into from May 3, 2024

Conversation

eddeee888
Copy link
Collaborator

This PR updates server preset guide with changes in server preset v0.8

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: be2cae2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 26, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/visitor-plugin-common 5.1.1-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 4.0.7-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 4.0.7-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 4.2.1-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 4.0.7-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 5.0.7-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 4.0.7-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 4.2.6-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 4.0.7-alpha-20240501114854-be2cae2a38a38384c61641094303eb8d7df5c819 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Apr 26, 2024

💻 Website Preview

The latest changes are available as preview in: https://58ddd9d2.graphql-code-generator.pages.dev

Comment on lines +411 to +415
fullName: async (_parent, _arg, _ctx) => {
/* User.fullName resolver is required because User.fullName exists but UserMapper.fullName does not */
},

isAdmin: ({ isAdmin }) => {
isAdmin: ({ isAdmin }, _arg, _ctx) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to this change? 🤔

Copy link
Collaborator Author

@eddeee888 eddeee888 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server preset now generates this by default, so I think matching it here helps set the user expectation 🙂

@eddeee888 eddeee888 merged commit d49124e into master May 3, 2024
20 checks passed
@eddeee888 eddeee888 deleted the update-server-preset-guide branch May 3, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants