fix(ci): pin nextjs version for nextjs-swc example #9737
Conversation
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
5.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/core |
4.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/add |
5.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/fragment-matcher |
5.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/introspection |
4.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/schema-ast |
4.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
4.1.0-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.1.0-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.2.0-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/testing |
3.0.1-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/plugin-helpers |
5.0.2-alpha-20231026070541-cb05739d0 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://f6b944a8.graphql-code-generator.pages.dev |
examples/react/nextjs-swr/codegen.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
for some reason though, I faced some errors regarding:
Type error: Cannot find module '@graphql-codegen/cli' or its corresponding type declarations.
1 | // eslint-disable-next-line import/no-extraneous-dependencies
> 2 | import { CodegenConfig } from '@graphql-codegen/cli'
when running yarn workspace example-react-nextjs-swr run build locally which I skipped with a // @ts-ignore for now, do you have any ideas on why is it throwing that?
|
not sure why End2End step fails @saihaj |
eddeee888
force-pushed
the
pin-nextjs-version
branch
2 times, most recently
from
1eaacf6
to
5a226cd
Compare
| ID: { input: string; output: string }; | ||
| String: { input: string; output: string }; | ||
| Boolean: { input: boolean; output: boolean }; | ||
| Int: { input: number; output: number }; | ||
| Float: { input: number; output: number }; |
There was a problem hiding this comment.
These were never updated because codegen/tests are executed sequentially... and this example was after some other failing tests 😓
| @@ -20,7 +20,7 @@ export function useGraphQL<TResult, TVariables>( | |||
| document.definitions.find(isOperationDefinition)?.name, | |||
| variables, | |||
| ] as const, | |||
| async (_key: string, variables: any) => | |||
| async ([_key, variables]: any) => | |||
There was a problem hiding this comment.
Looks like the current version of swr keeps the array as-is: https://swr.vercel.app/docs/arguments#multiple-arguments
In the previous versions (< 2.0.0), The fetcher function will receive the spreaded arguments from original key when the key argument is array type. E.g., key [url, token] will become 2 arguments (url, token) for fetcher function.
| getPeople().then(res => console.log(res)); | ||
| getPeople(10).then(res => console.log(res)); |
There was a problem hiding this comment.
These calls cause the Jest tests to fail. These also look like debugging statements that were never removed 🤔
| @@ -4,7 +4,7 @@ const fg = require('fast-glob'); | |||
|
|
|||
| const packageJSON = fg.sync(['examples/**/package.json'], { ignore: ['**/node_modules/**'] }); | |||
|
|
|||
| const ignoredPackages = ['example-react-nextjs-swr']; | |||
| const ignoredPackages = []; | |||
There was a problem hiding this comment.
We can now remove the example from the ignored array 🎉
I'll keep the current implementation in case we need to ignore tests in the future (hope that time never comes! 🤞 )
There was a problem hiding this comment.
looks good, @saihaj or @enisdenjo can you take a last look before merging?
eddeee888
force-pushed
the
pin-nextjs-version
branch
from
e905c28
to
ec5c7cb
Compare
No description provided.