Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import path module as variable instead of default in watcher #2125

Closed
wants to merge 1 commit into from
Closed

Import path module as variable instead of default in watcher #2125

wants to merge 1 commit into from

Conversation

therealtbs
Copy link

The usage later on gets transpiled by TypeScript into:

ignored.push(path_1.default.join(entry.filename, '**', '*' + extension));

Note the default, which is incorrect for a commonjs module and causes a crash.

This PR fixes that

@dotansimha
Copy link
Owner

dotansimha commented Jul 8, 2019

@therealtbs , actually, @mvestergaard just fixed it a minute after you, but I merged his PR first 😄 #2126

Thank you!!

@dotansimha dotansimha closed this Jul 8, 2019
@therealtbs
Copy link
Author

No worries! 😌 Just glad it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants