Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow codegen to skip schema building when it's not possible #2120

Merged
merged 1 commit into from Jul 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/graphql-codegen-cli/src/codegen.ts
Expand Up @@ -5,10 +5,11 @@ import { normalizeOutputParam, normalizeInstanceOrArray, normalizeConfig } from
import { prettify } from './utils/prettier';
import { Renderer } from './utils/listr-renderer';
import { loadSchema, loadDocuments } from './load';
import { GraphQLError, DocumentNode, buildASTSchema } from 'graphql';
import { GraphQLError, DocumentNode } from 'graphql';
import { getPluginByName } from './plugins';
import { getPresetByName } from './presets';
import { debugLog } from './utils/debugging';
import { tryToBuildSchema } from './utils/try-to-build-schema';

export const defaultLoader = (mod: string) => import(mod);

Expand Down Expand Up @@ -214,14 +215,15 @@ export async function executeCodegen(config: Types.Config): Promise<Types.FileOu
};

let outputs: Types.GenerateOptions[] = [];
const builtSchema = tryToBuildSchema(outputSchema);

if (hasPreset) {
outputs = await preset.buildGeneratesSection({
baseOutputDir: filename,
presetConfig: outputConfig.presetConfig || {},
plugins: normalizedPluginsArray,
schema: outputSchema,
schemaAst: buildASTSchema(outputSchema),
schemaAst: builtSchema,
documents: outputDocuments,
config: mergedConfig,
pluginMap,
Expand All @@ -232,7 +234,7 @@ export async function executeCodegen(config: Types.Config): Promise<Types.FileOu
filename,
plugins: normalizedPluginsArray,
schema: outputSchema,
schemaAst: buildASTSchema(outputSchema),
schemaAst: builtSchema,
documents: outputDocuments,
config: mergedConfig,
pluginMap,
Expand Down
12 changes: 12 additions & 0 deletions packages/graphql-codegen-cli/src/utils/try-to-build-schema.ts
@@ -0,0 +1,12 @@
import { DocumentNode, GraphQLSchema, buildASTSchema } from 'graphql';
import { debugLog } from './debugging';

export function tryToBuildSchema(schema: DocumentNode): GraphQLSchema {
try {
return buildASTSchema(schema);
} catch (e) {
debugLog(`Unable to build AST schema from DocumentNode, will try again later...`, e);

return null;
}
}