Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change detection when base is a tag #78

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Conversation

dorny
Copy link
Owner

@dorny dorny commented Mar 25, 2021

This PR fixes invalid assumption that base will always be a branch.
Instead it tries to determine full ref name using git show-ref.
If ref is still not available after first fetch, then it executes fetch again with --tags option.

It also changes behavior when no merge base is found .
Instead of returning all files as changed it performs direct comparison between two commits.

closes #77

@dorny dorny merged commit ad1ae68 into master Mar 25, 2021
@dorny dorny deleted the issue-77-tag-as-base-broken branch March 25, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version broke the giving a tag as base
1 participant