Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to actions/checkout@v3 in order to avoid the set-output depr… #164

Merged
merged 1 commit into from Oct 12, 2022

Conversation

IdanYaffe
Copy link
Contributor

…ecation warning

@dorny dorny merged commit 027a82c into dorny:master Oct 12, 2022
@IdanYaffe
Copy link
Contributor Author

@dorny I'm afraid that this is not enough.
looks like there's also a need in updating the "setOutput" call as per this doc:
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions

here are the places that I could find that are in need of this change:
https://github.com/dorny/paths-filter/search?q=%22setOutput%22

@IdanYaffe
Copy link
Contributor Author

@dorny looks like it was addressed by this PR in the "actions/typescript-action" repo:
https://github.com/actions/typescript-action/pull/611/files#diff-468016aae139513ca1e5421e59385204d06350f7fb00672a31184f70f4eb3425

@dorny
Copy link
Owner

dorny commented Oct 12, 2022

@IdanYaffe thanks for the notice. Here's a blog post about it - https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

So updating the package should be enough. I will do it now.

@IdanYaffe
Copy link
Contributor Author

IdanYaffe commented Oct 12, 2022

@dorny I'm afraid that's still not resolved.
if I'm not mistaken, we need to update the setOutput function in the index.js:
https://raw.githubusercontent.com/dorny/paths-filter/master/dist/index.js

should be something like this:
https://github.com/actions/typescript-action/blob/main/dist/index.js#L355-L362

@dorny
Copy link
Owner

dorny commented Oct 12, 2022

Yes, I have to update the index.js. It's a packaged version of all the code of this action and its dependencies. I usually do it just once after multiple PRs are merged, together with adding a new tag. The file is big so every change of it increases the size of the repo. Looks like I won't make more changes today so I will do a release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants