Use Octokit's pagination #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid an unnecessary API request at the end of the list of files.
|
@dorny Ping? |
mitchell-codecov
added a commit
to mitchell-codecov/paths-filter
that referenced
this pull request
Jun 15, 2022
…agination Merge dorny#129
mitchell-codecov
added a commit
to mitchell-codecov/paths-filter
that referenced
this pull request
Jun 15, 2022
commit 370fff3 Merge: 8c7f485 a09d4a5 Author: Mitchell Borrego <mitchell@codecov.io> Date: Wed Jun 15 17:29:37 2022 -0400 Merge pull request #2 from mitchell-codecov/anomiex-fix/use-octokit-pagination Merge dorny#129 commit a09d4a5 Merge: d1a550a 8c7f485 Author: Mitchell Borrego <mitchell@codecov.io> Date: Wed Jun 15 17:28:48 2022 -0400 Merge branch 'master' into anomiex-fix/use-octokit-pagination commit d1a550a Author: Mitchell Borrego <mitchell@codecov.io> Date: Wed Jun 15 17:19:43 2022 -0400 Squashed commit of the following: commit 8c7f485 Merge: 1ec7035 17e486d Author: Michal Dorner <dorner.michal@gmail.com> Date: Thu Jun 9 22:38:20 2022 +0200 Merge pull request dorny#121 from JJ/master Run audit fix with --force and a few other upgrades commit 17e486d Author: Michal Dorner <michal.dorner@synergysports.com> Date: Thu Jun 9 22:36:15 2022 +0200 Update eslint package commit bdd8d7a Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:56:38 2022 +0100 :sparkles: Generates code with new ncc commit 38e0a04 Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:55:41 2022 +0100 :arrow_up: in a number of deps To take care of deprecated upstream deps and somesuch commit 6b40481 Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:50:06 2022 +0100 :coffin: rules no longer used commit b55f63c Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:48:18 2022 +0100 Fix resulting dep errors :bug: commit 816eb04 Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:38:06 2022 +0100 Run audit fix with --force commit 8c7f485 Merge: 1ec7035 17e486d Author: Michal Dorner <dorner.michal@gmail.com> Date: Thu Jun 9 22:38:20 2022 +0200 Merge pull request dorny#121 from JJ/master Run audit fix with --force and a few other upgrades commit 17e486d Author: Michal Dorner <michal.dorner@synergysports.com> Date: Thu Jun 9 22:36:15 2022 +0200 Update eslint package commit b9703a9 Author: Brad Jorsch <anomie@users.sourceforge.net> Date: Fri Feb 25 14:23:27 2022 -0500 Use Octokit's pagination This will avoid an unnecessary API request at the end of the list of files. commit bdd8d7a Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:56:38 2022 +0100 :sparkles: Generates code with new ncc commit 38e0a04 Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:55:41 2022 +0100 :arrow_up: in a number of deps To take care of deprecated upstream deps and somesuch commit 6b40481 Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:50:06 2022 +0100 :coffin: rules no longer used commit b55f63c Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:48:18 2022 +0100 Fix resulting dep errors :bug: commit 816eb04 Author: JJ Merelo <jjmerelo@gmail.com> Date: Tue Feb 1 07:38:06 2022 +0100 Run audit fix with --force
Merged
|
Hey @anomiex, thanks for the PR. I must apologize for responding almost 8 months later, but I was inactive on the project for some time. I won't merge this PR as is because the dist/index.js was modified. For multiple reasons, I do this only when I'm adding a new tagged release. I've taken your changes and created a new PR #163 |
|
Seems to be working fine. I'm merging #163 and closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid an unnecessary API request at the end of the list of
files.