Allow a TokenResponse body to be customized #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbulaj
approved these changes
Mar 12, 2024
We have a use case where we need to include some additional information
in the token response body to help the client applications with our
multi-tenant setup.
Adding the memoization allows us to modify the body object during the
after_successful_authorization callback:
```ruby
after_successful_authorization do |controller, context|
case context.auth
when Doorkeeper::OAuth::TokenResponse
context.auth.body["tenant_id"] = context.auth.token.tenant_id
end
end
```
(Assuming that `tenant_id` was added to `custom_access_token_attributes`.)
I considered adding attributes via `custom_access_token_attributes` in
`#body` directly, but that would change the existing behavior of the
`TokenResponse` everywhere.
kmayer
force-pushed
the
kmayer-customzied-token-response
branch
from
4688196
to
01343d1
Compare
|
rebased.
…On Tue, Mar 12, 2024 at 1:27 AM Nikita Bulai ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM 👍
Can you please rebase? 🙏
—
Reply to this email directly, view it on GitHub
<#1697 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEZZBUQ4ZTS5TWB22L7ATYX2365AVCNFSM6AAAAABEPRZZV2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZQGM4DQMBQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
***@***.*** | (808) 722-6142 (c)
|
|
@kmayer |
|
There’s an example in the commit message.
…--
***@***.*** | (808) 722-6142 (c)
On Mar 13, 2024 at 5:06 AM -0700, Alex Lykesas ***@***.***>, wrote:
@kmayer
I am also interested using this. Can you provide an example how to customize the body response?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we need to include some additional information in the token response body to help the client applications with our multi-tenant setup.
Adding the memoization allows us to modify the body object during the after_successful_authorization callback:
(Assuming that
tenant_idwas added tocustom_access_token_attributes.)I considered adding attributes via
custom_access_token_attributesin#bodydirectly, but that would change the existing behavior of theTokenResponseeverywhere.