Use validates_with rather than validates to validate URI #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveModel's validates method uses string manipulation, in particular camelize, to identify the class constant to be used for validation. If inflections have been modified or added, it may attempt to load a class that does not exist. By using validates_with and passing the exact class to be used, we can avoid this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today my project upgraded from Doorkeeper 5.3.2 to 5.6.6. In the process, we started encountering errors like the following:
After much investigating, we determined that we have an inflection configured in a Rails initializer for the string
URI:This causes ActiveModel to attempt to load
Doorkeeper::RedirectURIValidatorrather than the correctDoorkeeper::RedirectUriValidator, here. The fix I'm suggesting in this PR is to avoid ActiveModel's attempt to guess the proper constant name, and instead use the constant directly by providing it tovalidates_with, which is whatvalidatesdoes anyways. I'm absolutely open to other suggestions on how to make this more resistant to custom inflection configurations.