Add custom attributes support to token generator #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insecure Use of Language/Framework API (1)
More info on how to fix Insecure Use of Language/Framework API in Ruby. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
|
@JeremyC-za I would like to have your opinion here since it's based on your PR. Thanks! |
nbulaj
reviewed
Apr 10, 2023
|
Could you please also add a changelog entry? And squash the commits then 🙇 Thanks in advance |
Use variable to send attribute call Add specs Use public_send instead of send Update changelog
raphaelcosta
force-pushed
the
feature/add-custom-attributes-to-token-generator
branch
from
9ac9b99
to
4e95934
Compare
Done, thanks! |
|
Thanks @raphaelcosta ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support to the custom attributes added by the PR #1602 in the custom access_token_generator. It's now possible to use the custom attributes in the JWT payload for example.
Other Information
Related PR #1602