Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong params fix for Rails forms #1297

Closed

Conversation

georgepalmer
Copy link
Contributor

Fix for part of #1287

As a Rails form will include other params such as a commit, utf_8 and authenticity_token we need to pull out only the params we require or we'll get a strong params exception when running Rails with the setting:

config.action_controller.action_on_unpermitted_parameters = :raise

As a Rails form will include other params such as a commit, utf_8 and authenticity_token we pull out only the params we require
@doorkeeper-bot
Copy link

doorkeeper-bot commented Aug 12, 2019

3 Warnings
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.
⚠️ Please include a changelog entry.
You can find it at CHANGELOG.md.You can skip this warning only if you made some typo fix or other small changes that didn’t affect the API.
⚠️ Please squash all your commits to a single one

Here's an example of a CHANGELOG.md entry:

- [#1297] Strong params fix for rails forms.

Generated by 🚫 Danger

@georgepalmer
Copy link
Contributor Author

Closing this off for a PR with squashed commits

@georgepalmer georgepalmer deleted the strong-params-fix branch August 13, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants