Rename encryption_method to signing_method #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 24, 2023
spec/doorkeeper/jwt_spec.rb
Outdated
| @@ -101,14 +121,15 @@ | |||
| expect(decoded_token[1]["alg"]).to eq "HS256" | |||
| end | |||
|
|
|||
| it "creates a signed encrypted JWT token with a custom dynamic payload" do | |||
|
|
|||
There was a problem hiding this comment.
Layout/EmptyLines: Extra blank line detected.
spec/doorkeeper/jwt_spec.rb
Outdated
| @@ -65,10 +65,10 @@ | |||
| expect(decoded_token[1]["alg"]).to eq "none" | |||
| end | |||
|
|
|||
| it "creates a signed encrypted JWT token" do | |||
| it "creates a signed JWT token" do | |||
There was a problem hiding this comment.
RSpec/RepeatedDescription: Don't repeat descriptions within an example group.
nbulaj
reviewed
Jun 15, 2023
|
When can this be merged? |
Just saw your reply, backward compatibility is actually kept with https://github.com/doorkeeper-gem/doorkeeper-jwt/pull/53/files#diff-74e4c64e2f216da896bfaa36c9fa1f58c3e9cbcb042932181d997d3a51510b7fR43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library does not do encryption and the JWT tokens are readable by anyone.
Using the word "encryption" makes it seem it is safe to store sensible data in the payload when it is clearly not. Encrypted JWT tokens are called JWE tokens and are not supported by this library or by ruby-jwt.
What this library does however is signing the tokens to ensure they were created by a trusted party.
I renamed encryption_method to signing_method and updated the README to specify "signing" instead of "encryption".
It is still possible to use encryption_method for backward compatibility but this now deprecated.