Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement marshaling for BlockNumber #821

Merged
merged 3 commits into from Apr 27, 2023
Merged

Implement marshaling for BlockNumber #821

merged 3 commits into from Apr 27, 2023

Conversation

Djadih
Copy link
Contributor

@Djadih Djadih commented Apr 26, 2023

@dominant-strategies/core-dev
Inspired by ethereum/go-ethereum#23324

@Djadih Djadih added the enhancement New feature or request label Apr 26, 2023
@Djadih Djadih added this to the Iron Age milestone Apr 26, 2023
@Djadih Djadih self-assigned this Apr 26, 2023
wizeguyy
wizeguyy reviewed Apr 27, 2023
View reviewed changes
rpc/types.go Show resolved Hide resolved
@wizeguyy wizeguyy self-requested a review April 27, 2023 16:02
wizeguyy
wizeguyy previously approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Will approve again after rebase

@Djadih Djadih requested a review from wizeguyy April 27, 2023 17:16
gameofpointers
gameofpointers previously approved these changes Apr 27, 2023
View reviewed changes
@Djadih
Copy link
Contributor Author

Djadih commented Apr 27, 2023

Imported test from geth. Results below


=== RUN   TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal
=== RUN   TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/max
--- PASS: TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/max (0.00s)
=== RUN   TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/pending
--- PASS: TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/pending (0.00s)
=== RUN   TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/latest
--- PASS: TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/latest (0.00s)
=== RUN   TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/earliest
--- PASS: TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal/earliest (0.00s)
--- PASS: TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal (0.00s)
PASS
ok  	github.com/dominant-strategies/go-quai/rpc	0.353s```

@gameofpointers gameofpointers self-requested a review April 27, 2023 17:48
gameofpointers
gameofpointers previously approved these changes Apr 27, 2023
View reviewed changes
wizeguyy
wizeguyy previously approved these changes Apr 27, 2023
View reviewed changes
@Djadih Djadih dismissed stale reviews from wizeguyy and gameofpointers via 20d345b April 27, 2023 19:37
@gameofpointers gameofpointers self-requested a review April 27, 2023 19:37
@wizeguyy wizeguyy self-requested a review April 27, 2023 19:37
@Djadih Djadih merged commit 20d345b into dominant-strategies:main Apr 27, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeguyy wizeguyy wizeguyy approved these changes

@gameofpointers gameofpointers gameofpointers approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

Assignees

@Djadih Djadih

Labels
enhancement New feature or request
Projects
No open projects
Iron Age Testnet
Status: Complete
Milestone
Iron Age
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Djadih @wizeguyy @gameofpointers