Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tags #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support tags #35

wants to merge 3 commits into from

Conversation

andidevi
Copy link

@andidevi andidevi commented Apr 4, 2018

This supports a tags field, which will contain an array of tags pointing to that commit.

@domharrington
Copy link
Owner

This looks good. Would you mind adding a more specific test to show what the output of this array would look like? I'm having a hard time figuring it out from looking at the code.

@andidevi
Copy link
Author

This is just an array of strings containing the tag names add to that commit.

@andidevi
Copy link
Author

The failing test is
returns C100 status for files that are copied
which seems pretty unrelated to my changes. It's sucessfully on my system, so I've no idea what to change.

@andidevi
Copy link
Author

as its failing on nodejs 8 only it seems that this is an unrelated incompatibility of the C100 test.

@andidevi
Copy link
Author

andidevi commented Apr 13, 2018

comparing to #36 it seems, that one must request more fields than only ['tags'] to keep the C100 test working on nodejs 8. so there are some hidden assumptions in the test/code that should be fixed there.

If not, you may accept #36 instead of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants