Existing output file should be deleted/overwritten

[patrikwlund]

The CLI currently uses File.OpenWrite(path) (added in #2677) to create an output stream for the resulting swagger document. This does not delete the existing contents, but instead starts writing from position 0, causing issues if the output is smaller than the previous file content.

I changed it to File.Create(path) to make sure any previous content is discarded.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (f16fa78) to head (fa12574).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
- Coverage   90.30%   89.87%   -0.44%     
==========================================
  Files          75       72       -3     
  Lines        2857     2706     -151     
  Branches      457      428      -29     
==========================================
- Hits         2580     2432     -148     
+ Misses        277      274       -3     

Flag	Coverage Δ
Linux	89.87% <ø> (+2.66%)	⬆️
Windows	?
macOS	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martincostello]

Thanks for the fix - it looks like this is creating some sort of race condition though.

[patrikwlund]

Thanks for the fix - it looks like this is creating some sort of race condition though.

After investigating, I don't think that is related to this PR, as I can reproduce that on the master branch as well. Rebuilding the test/WebSites/CliExample project often (but not always) causes the "being used by another process" exception.

It may be because it's building net6, net7, and net8 concurrently, and all of them try to output to the same test/WebSites/CliExample/wwwroot/swagger/v1/swagger.json file in that project. It happens regardless of File.OpenWrite() or File.Create().

[martincostello]

I've re-run the CI for a third time now, but if it keeps failing it will need fixing in order to be merged.

[martincostello]

It's possible/probable that while it's an existing issue, the presence of the additional test is crossing a threshold that makes it more likely to happen.

If you can't easily fix it, we could temporarily skip the new test (I'm happy conceptually it's covering the issue and the bug is fixed) for now, and re-enable it later.

[patrikwlund]

I'll try removing the new test and at least see if it makes a difference in CI.

[martincostello]

I'll try removing the new test and at least see if it makes a difference in CI.

I suspect it will because dependabot just ran and there were no failures.

[martincostello]

If it does "fix" it, can you put it back but just mark it as skipped please?

[martincostello]

Fixes #2887.

[martincostello]

And green - just needs the skipped test and then I'll merge 👍

[martincostello]

Thanks - I've created #2893 to track the underlying flakiness and we can un-skip the test when we resolve that issue.