Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when a user uses FromForm attribute with IFormFile in … #2840

Merged
merged 5 commits into from Apr 27, 2024
Merged

Throw an error when a user uses FromForm attribute with IFormFile in … #2840

merged 5 commits into from Apr 27, 2024
+103 −0

Conversation

nikunjbhargava
Copy link
Contributor

…controller methods

martincostello
martincostello reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test.

src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs Outdated Show resolved Hide resolved
src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/ApiParameterDescriptionExtensions.cs Outdated Show resolved Hide resolved
@nikunjbhargava nikunjbhargava force-pushed the Throw-Error-When-FromFrom-Attribute-Used-With-IFormFile branch from 1e272a5 to de16696 Compare April 26, 2024 16:04
@nikunjbhargava nikunjbhargava marked this pull request as ready for review April 26, 2024 16:09
@nikunjbhargava
Copy link
Contributor Author

Needs a test.

Added

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (3416927) to head (22cfe86).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
+ Coverage   92.06%   92.37%   +0.31%     
==========================================
  Files          93       93              
  Lines        3111     3160      +49     
  Branches      536      556      +20     
==========================================
+ Hits         2864     2919      +55     
+ Misses        247      241       -6
Flag Coverage Δ
Linux 92.37% <100.00%> (+0.31%) ⬆️
Windows 92.37% <100.00%> (+0.31%) ⬆️
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v6.6.0 milestone Apr 27, 2024
@martincostello martincostello merged commit 1088d70 into domaindrivendev:master Apr 27, 2024
9 checks passed
@martincostello
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikunjbhargava @codecov-commenter @martincostello