Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that XML comment examples do not show up if the type is string and the example contains quotation marks #2727

Merged
merged 6 commits into from
May 6, 2024
Merged

Fix that XML comment examples do not show up if the type is string and the example contains quotation marks #2727

merged 6 commits into from
May 6, 2024

Commits on May 5, 2024

  1. Fix that XML comment examples do not show up if the type is string an… 

    …d the example contains quotation marks
    @dldl-cmd
    dldl-cmd committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a18bb77 View commit details
    Browse the repository at this point in the history

  2. allow schema to be null in example creation

    @dldl-cmd
    dldl-cmd committed May 5, 2024
    Configuration menu
    Copy the full SHA
    6f6837c View commit details
    Browse the repository at this point in the history

  3. Adapt suggestion from code review 

    - use static string.Equals
- assert for not null and correct type
    @dldl-cmd
    dldl-cmd committed May 5, 2024
    Configuration menu
    Copy the full SHA
    8186b21 View commit details
    Browse the repository at this point in the history

  4. Make XmlCommentsExampleHelper internal

    @dldl-cmd
    dldl-cmd committed May 5, 2024
    Configuration menu
    Copy the full SHA
    6e225b9 View commit details
    Browse the repository at this point in the history

  5. Update asserts

    @dldl-cmd
    dldl-cmd committed May 5, 2024
    Configuration menu
    Copy the full SHA
    9020e18 View commit details
    Browse the repository at this point in the history

  6. PR suggestions, adapting asserts

    @dldl-cmd
    dldl-cmd committed May 5, 2024
    Configuration menu
    Copy the full SHA
    7989435 View commit details
    Browse the repository at this point in the history