Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support [DataMember] IsRequired in NewtonsoftDataContractResolver #2644

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support [DataMember] IsRequired in NewtonsoftDataContractResolver #2644

wants to merge 3 commits into from

Conversation

ouvreboite
Copy link

@ouvreboite ouvreboite commented May 3, 2023 •
edited

cf #2383

  • Add non-regression tests to ensure [DataMember(IsRequired)] do not bypass existing [JsonObject], [JsonProperty] or [JsonRequired] attributes.
  • Add tests for [DataMember(IsRequired)] and [DataMember(name)]
  • Update NewtonsoftDataContractResolver to directly leverage jsonProperty.Required, instead of using the IsRequiredSpecifed extension method
  • Move tests to net7 to fix CI

@ouvreboite
✅ Add non-regression tests for DataMember required
810b4cc 
As DataMember implementation comes after the implementation for [JsonProperty] and [JsonObject], we want to be sure that the current behavior is not bypassed.
@ouvreboite
✨Add support for [DataMember(IsRequired)]
4c97c92 
Add test cases for DataMember (IsRequired and Name).
It seems that NewtonSoft's ResolveContract correctly set the Required, using [DataMember], [JsonProperpty] and [JsonRequired] so we can directly use it instead of the IsRequiredSpecifed extension method.
@ouvreboite
💚Move tests to net7 to fix build
a8e2841
@schnerring schnerring mentioned this pull request Jun 16, 2023
Closed
Havunen added a commit to Havunen/DotSwashbuckle2 that referenced this pull request Feb 12, 2024
@Havunen
Port domaindrivendev/Swashbuckle.AspNetCore#2644 for Havunen/DotSwash…
328b0ec 
…buckle#1
Havunen added a commit to Havunen/DotSwashbuckle that referenced this pull request Feb 18, 2024
@Havunen
Port domaindrivendev#2644 for #1 credits @ouvreboite
d46b373
@martincostello
Copy link
Collaborator

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. We'd also require tests for this scenario.

@martincostello martincostello mentioned this pull request Apr 14, 2024
Open
@ouvreboite
Copy link
Author

I'll rebase once #2799 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ouvreboite @martincostello