Fix empty index.html if default serializer options are changed #2621
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Index.html` is generated incorrectly if `System.Text.Json`'s default serializer options are changed, e.g. if `WriteIndented` is `true` and `DefaultIgnoreCondition` is `JsonIgnoreCondition.Never`, it produces the following text inside `index.html`:
```
var interceptors = JSON.parse('{
"requestInterceptorFunction": null,
"responseInterceptorFunction": null
}');
```
... which will generate `index.html:100 Uncaught SyntaxError: Invalid or unexpected token` error and show blank document in the browser.
|
Hey guys! It seems like appveyor tests fail because .NET 6 is not installed. I didn't work with appveyor before. How this can be fixed? |
hell-racer
changed the title
Havunen
added a commit
to Havunen/DotSwashbuckle2
that referenced
this pull request
Feb 11, 2024
Havunen
added a commit
to Havunen/DotSwashbuckle
that referenced
this pull request
Feb 18, 2024
|
Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. Could you also add a test for this scenario? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index.htmlis generated incorrectly ifSystem.Text.Json's default serializer options are changed, e.g. ifWriteIndentedistrueandDefaultIgnoreConditionisJsonIgnoreCondition.Never, it produces the following text insideindex.html:... which will generate
index.html:100 Uncaught SyntaxError: Invalid or unexpected tokenerror and show blank document in the browser.