Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pathbase): Add support for app.UsePathBase #2615

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

underwoodcode
Copy link

This is a minor change to add support for PathBase.

In cases where the API needs to use app.UsePathBase("some/path"), getting Swagger UI to conform to this path with RoutePrefix was a little involved. This change adds a PathBase property that should be set to the same value defined in app.UsePathBase().

From there, it checks the incoming request to see if path base is defined and the PathBase property is populated.

If PathBase is populated, but the incoming request path does not contain PathBase, then Swagger UI will not be displayed.

If PathBase is populated and the incoming request path contains the same PathBase value, then Swagger UI will be displayed.

If PathBase is not populated and the incoming request does not contain a PathBase value, then the normal workflow will display the Swagger UI.

@martincostello
Copy link
Collaborator

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. Tests would also be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants