Fix null value handling in OpenApiAnyFactory. #2102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjsdtc
changed the title
|
I believe this is already fixed by #2151. If not, please create a new issue describing the problem complete with exact repro steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing bool value parsing issue (#2092) I found that my changes to the code did not handle the null value in json correctly, and if there is null values, it will crash the whole parsing process. Also, my test case did not cover this situation.
Here is my additional fix for handling null values, with modified test cases covering this. Please feel free to let me know if you have any suggestions or additional changing requirements.