Xpp fixes #22
Open
Xpp fixes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting method name to implement abstract method removeAtttributes() -> removeAttributes()
Implemented abstract method boolean removeAttributeByName(String,String)
Implemented abstract method boolean removeAttributeByRawName(String)
|
I see why this failed and it is odd. Pulling current sources and compiling them I run into an opposite error, thus the patches. Gradle only shows a dep of xpp3, but I have to have xpp2 in addition to xpp3 to compile this package. Not sure what is going on there. But these patches were necessary to get dom4j 2.0 to compile from source on Gentoo. https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/dom4j/dom4j-9999.ebuild |
|
I think the patch should also update the version of pull-parser:pull-parser in build.gradle to 2.1.10 |
|
dom4j 2.1.x branch stay on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with xpp. Ran into several abstract methods not implemented from XmlStartTag in ProxyXmlStartTag. Renamed removeAtttributes -> removeAttributes. Implemented missing removeAttributeByName and removeAttributeByRawName. This PR fixes those issues and allows it to compile.