Reuse the writeAttribute method in writeAttributes. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works beautifully! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm currently using dom4j for a plugin and need to modify the output of attributes. Currently I need to override the writeAttributes method which do contain the private field namespaceStack and I need to use reflection to access the field, which is not ideal.
If writeAttributes could call the writeAttribute method this would help a lot. Then I only would need to override the smaller writeAttribute method and it does not contain any private fields.
Both methods use the same code, so it would be possible reuse the methods. The only line that stands out is that writeAttribute contains the line
lastOutputNodeType = Node.ATTRIBUTE_NODE;, but I do not think that this affects the output.Sincerely, Björn