Support for system schema #2471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2024
zachmu
approved these changes
Jun 5, 2024
| StatsProvider sql.StatsProvider | ||
| MySQLDb *mysql_db.MySQLDb | ||
| InfoSchema sql.Database | ||
| SystemSchemaConfig *sql.SystemSchemaConfig |
There was a problem hiding this comment.
This seems fine for the time being, but ideally GMS wouldn't not need to treat the pg_catalog schema differently from any other database it handles. We could handle all of this on the Dolt / Doltgres side (new database provider that knows about the pg_catalog database), it's just currently difficult to plumb the necessary information through when building the engine.
But that's hard to do, and I don't have an issue with doing this as a quick fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuring system schema, to support additional databases similar to
information_schema. Will be used to supportpg_catalogfor doltgres