Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream: static build #7

Merged
merged 1 commit into from
Apr 8, 2023
Merged

upstream: static build #7

merged 1 commit into from
Apr 8, 2023

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Apr 4, 2023

Description

upstream PR: ethereum/go-ethereum#25492

This adds a new flag to the ci.go install script, -static which produces static linked binary.

@0xcb9ff9 0xcb9ff9 added the enhancement New feature or request label Apr 4, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Apr 4, 2023
DarianShawn
DarianShawn previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarianShawn DarianShawn changed the title upstream: static build #6 upstream: static build Apr 7, 2023
@DarianShawn DarianShawn merged commit dc2a5af into dev Apr 8, 2023
5 checks passed
@DarianShawn DarianShawn deleted the upstream/static_build branch April 8, 2023 02:22
@0xcb9ff9 0xcb9ff9 mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xcb9ff9 @DarianShawn