Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-jest from 23.20.0 to 24.0.0 #2234

Merged
merged 2 commits into from Sep 10, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 8, 2020

Bumps eslint-plugin-jest from 23.20.0 to 24.0.0.

Release notes

Sourced from eslint-plugin-jest's releases.

v24.0.0

24.0.0 (2020-09-04)

Bug Fixes

Code Refactoring

  • no-test-callback: rename rule to no-done-callback (#653) (e15a8d1)

Features

  • no-done-callback: support hooks (#656) (3e6cb44), closes #649 #651
  • add no-conditional-expect to the recommended ruleset (40cd89d)
  • add no-deprecated-functions to the recommended ruleset (5b2af00)
  • add no-interpolation-in-snapshots to the recommended ruleset (3705dff)
  • add valid-title to recommended ruleset (41f7873)
  • drop support for node 8 (#570) (6788e72)
  • set no-jasmine-globals to error in recommended ruleset (7080952)
  • no-large-snapshots: remove whitelistedSnapshots option (8c1c0c9)

BREAKING CHANGES

  • no-done-callback: no-done-callback will now report hooks using callbacks as well, not just tests
  • no-test-callback: rename no-test-callback to no-done-callback
  • recommend no-conditional-expect rule
  • recommend no-interpolation-in-snapshots rule
  • recommend no-deprecated-functions rule
  • recommend valid-title rule
  • recommend erroring for no-jasmine-globals rule
  • no-large-snapshots: no-large-snapshots runs on all files regardless of type
  • Jasmine globals are no marked as such
  • Node 10+ required
Changelog

Sourced from eslint-plugin-jest's changelog.

24.0.0 (2020-09-04)

Bug Fixes

Code Refactoring

  • no-test-callback: rename rule to no-done-callback (#653) (e15a8d1)

Features

  • no-done-callback: support hooks (#656) (3e6cb44), closes #649 #651
  • add no-conditional-expect to the recommended ruleset (40cd89d)
  • add no-deprecated-functions to the recommended ruleset (5b2af00)
  • add no-interpolation-in-snapshots to the recommended ruleset (3705dff)
  • add valid-title to recommended ruleset (41f7873)
  • drop support for node 8 (#570) (6788e72)
  • set no-jasmine-globals to error in recommended ruleset (7080952)
  • no-large-snapshots: remove whitelistedSnapshots option (8c1c0c9)

BREAKING CHANGES

  • no-done-callback: no-done-callback will now report hooks using callbacks as well, not just tests
  • no-test-callback: rename no-test-callback to no-done-callback
  • recommend no-conditional-expect rule
  • recommend no-interpolation-in-snapshots rule
  • recommend no-deprecated-functions rule
  • recommend valid-title rule
  • recommend erroring for no-jasmine-globals rule
  • no-large-snapshots: no-large-snapshots runs on all files regardless of type
  • Jasmine globals are no marked as such
  • Node 10+ required
Commits
  • 1392cf3 chore(release): 24.0.0 [skip ci]
  • 3e6cb44 feat(no-done-callback): support hooks (#656)
  • 99774cd chore: migrate to yarn v2 (#655)
  • e15a8d1 refactor(no-test-callback): rename rule to no-done-callback (#653)
  • 5e3ba0e chore: upgrade to typescript@4 (#650)
  • 40cd89d feat: add no-conditional-expect to the recommended ruleset
  • 3705dff feat: add no-interpolation-in-snapshots to the recommended ruleset
  • 5b2af00 feat: add no-deprecated-functions to the recommended ruleset
  • 41f7873 feat: add valid-title to recommended ruleset
  • 7080952 feat: set no-jasmine-globals to error in recommended ruleset
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file javascript labels Sep 8, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-jest-24.0.0 branch from 22c49f2 to 5a92bc4 Compare September 8, 2020 09:15
@chvp
Copy link
Member

chvp commented Sep 9, 2020

Reason we fail is this PR: jest-community/eslint-plugin-jest#596. IIRC we use require because it has slightly different semantics than import (see #1998). Not sure what the best course of action is here. Can we just add require as a global somewhere?

@bmesuere
Copy link
Member

bmesuere commented Sep 9, 2020

Or eslint-disable-next-line ? :)

@chvp
Copy link
Member

chvp commented Sep 9, 2020

Good point 🤦. I'll do this tomorrow.

@bmesuere bmesuere merged commit 5d40543 into develop Sep 10, 2020
@bmesuere bmesuere deleted the dependabot/npm_and_yarn/eslint-plugin-jest-24.0.0 branch September 10, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants