Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1092

Merged
merged 3 commits into from Aug 5, 2022
Merged

Update dependencies #1092

merged 3 commits into from Aug 5, 2022

Conversation

juliusfitzhugh-ccpo
Copy link
Contributor

No description provided.

@juliusfitzhugh-ccpo juliusfitzhugh-ccpo requested a review from a team August 4, 2022 12:43
@kylelaker-ccpo
Copy link
Contributor

Oof not sure what's up with that build failure

@juliusfitzhugh-ccpo
Copy link
Contributor Author

@kylelaker-ccpo okay, so it's not just me I was trying to wrap my mind around the issue, no luck either.

@kylelaker-ccpo
Copy link
Contributor

It looks like maybe npm update bumped the version of yargs-parser? Maybe that's (part of) the issue? Not really sure. But it definitely seems related to the error message.

@kylelaker-ccpo
Copy link
Contributor

Ahh yeah yargs/yargs-parser#452 seems related

@juliusfitzhugh-ccpo
Copy link
Contributor Author

yeah, that definitely is the same error we're getting. Do we just wait for that issue to be fixed? Or is there something else we can do?

This includes additional dependency updates, including one that
hopefully fixes `yargs-parser` related errors in `tsc`.
@kylelaker-ccpo
Copy link
Contributor

kylelaker-ccpo commented Aug 5, 2022

How did I end up with merge conflicts when I did that? Okay... uhh let me work that out.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juliusfitzhugh-ccpo
Copy link
Contributor Author

Thanks for the additions! Looks like the issue was fixed for yargs-parser. I would approve, but not allowed 😆.
@jeffsaunders-hacc @zachclark-ccpo can one of you approve this PR?

Copy link
Contributor

@kylelaker-ccpo kylelaker-ccpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with just approving. It's dependencies only and if we're both good with the changes, I think that's sufficient.

@kylelaker-ccpo kylelaker-ccpo merged commit cab9c37 into develop Aug 5, 2022
@kylelaker-ccpo kylelaker-ccpo deleted the feature/20220804 branch August 5, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants