Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/update docs tests failing on master #1442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavideDaniel
Copy link
Contributor

@DavideDaniel DavideDaniel commented Nov 18, 2021

Results of running npm run build and assessing npm test on master.

On master running npm test yields:
image

Update: above was resolved by running npm ci first so I dropped the commit to amend tests.

Running npm run build results in self documentation breaking:
image
image

@DavideDaniel
Copy link
Contributor Author

Why are there differences in CI and local? I'm running node 14.18.1 but locally tests fail due to the additional \\ but in CI I can see it failing from the lack of. Does anyone know?

@anthony-redFox
Copy link
Member

@DavideDaniel you need to update your local packages, just execute npm ci

@DavideDaniel
Copy link
Contributor Author

DavideDaniel commented Nov 19, 2021

On master, on node v14.18.1, ran npm ci and then npm run build and the command breaks in the midst of parsing own file.
image
image

Investigating underlying issue with konan@2.1.1 but if you don't have this happening on your end @anthony-redFox , please let me know.

@DavideDaniel
Copy link
Contributor Author

The problem is when konan parses https://github.com/documentationjs/documentation/blob/master/src/output/html.js#L23-L26
The dynamic import statements are not properly evaluated here https://github.com/egoist/konan/blob/master/index.js#L40
This is causing npm run build to break the self documenting, which probably means it would break for others as well.
image

There is an option to disable detecting dynamic imports: https://github.com/egoist/konan#dynamicimport, which does seem to fix the issue.
image

@DavideDaniel DavideDaniel force-pushed the task/update-docs-tests-failing-on-master branch from 48c7d80 to 8d65e43 Compare November 19, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants