Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string and number literal types #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

motiz88
Copy link

@motiz88 motiz88 commented Jun 3, 2016

This fixes breakage I've seen when trying to generate HTML documentation from Flow types that contain literal types as their members, (e.g. member types of disjoint unions). String and number literals are both supported to match Flow. (Possibly booleans are also needed? The Flow changelog hints at this)

I couldn't figure out how to add proper tests, unfortunately, but the minimal case that used to cause errors is running documentation build --format html on the following two variations of the same code:

/**
 * A
 */
type A = {tag: 'A';};
/**
 * A
 */
type A = {tag: 1;};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant