Deprecate QueryBuilder APIs exposing its internal state #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sergei Morozov <morozov@tut.by>
derrabus
force-pushed
the
deprecate/query-builder-state
branch
from
3b882bc
to
d3664d0
Compare
derrabus
requested review from
greg0ire and
SenseException
and removed request for
greg0ire
SenseException
approved these changes
Jul 31, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 2, 2022
* 2.13.x: Deprecate QueryBuilder APIs exposing its internal state (doctrine#9945) Update branch info in README and .doctrine-project.json (doctrine#9943) Psalm 4.25.0, PHPStan 1.8.2 (doctrine#9941) Stop passing event manager to constructor (doctrine#9938) Use a more precise phpdoc for ClassMetadataInfo::versionField than mixed (doctrine#9937) Make EntityManager `@final` and its constructor public
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 3, 2022
* 2.13.x: Deprecate QueryBuilder APIs exposing its internal state (doctrine#9945) Update branch info in README and .doctrine-project.json (doctrine#9943) Psalm 4.25.0, PHPStan 1.8.2 (doctrine#9941) Stop passing event manager to constructor (doctrine#9938) Use a more precise phpdoc for ClassMetadataInfo::versionField than mixed (doctrine#9937) Make EntityManager `@final` and its constructor public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a shameless copy of doctrine/dbal#5551 by @morozov. I'd like to deprecate those methods for the same reasons as they've been deprecated in DBAL.