Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type declarations where backwards-compatible #8544

Merged
merged 1 commit into from Apr 19, 2021

Commits on Apr 19, 2021

  1. Add type declarations where backwards-compatible

    This includes:
    - private methods
    - return type declarations of final protected methods
    - return type declarations of public and protected methods of final classes
    
    Parameter type declarations are a more delicate matter and should
    probably be handled separately to make it easier to catch issues during
    code review.
    
    Type declarations can be more trusted than simple phpdoc when it
    comes to static analysis, having them means we can infer the phpdoc of
    calling methods with confidence.
    
    Note that it seems that some of the phpdoc I initially inferred these
    declarations from were apparently wrong, in particular some mentioning
    Doctrine\Dbal\Statement when was is really passed around is
    Doctrine\Dbal\Driver\Statement.
    greg0ire committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    55f030f View commit details
    Browse the repository at this point in the history