Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for passing optimistic lock version as string #8533

Merged
merged 1 commit into from Mar 11, 2021
Merged

Add test coverage for passing optimistic lock version as string #8533

merged 1 commit into from Mar 11, 2021

Commits on Mar 11, 2021

  1. Add test coverage for passing optimistic lock version as string 

    As discussed in doctrine#8527, when using optimistic locking with integer
version columns, Doctrine has always supported passing the lock
version as a string. For example when passing in a version
received in POST / GET.

Technically speaking this does not comply with the docs and phdoc
(which show the app explicitly casting to int before passing).

Nonetheless the maintainers decided it should continue to be valid
for now and reinstated the old soft-equals logic with doctrine#8531.

This modified test just avoids accidental changes in future.
    @acoulton
    acoulton committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    77356b9 View commit details
    Browse the repository at this point in the history