Fix bug when using Result Cache with Query::toIterable

[Warxcell]

Argument 1 passed to Doctrine\ORM\Internal\Hydration\AbstractHydrator::toIterable() must implement interface Doctrine\DBAL\Driver\Statement, instance of Doctrine\DBAL\Cache\ResultCacheStatement given, called in /app/vendor/doctrine/orm/lib/Doctrine/ORM/AbstractQuery.php on line 1010

[Warxcell]

Error: Method \Doctrine\ORM\Internal\Hydration\AbstractHydrator::gatherRowData() does not have @param annotation for its traversable parameter $id. Error: Method \Doctrine\ORM\Internal\Hydration\AbstractHydrator::gatherRowData() does not have @param annotation for its traversable parameter $nonemptyComponents.

Whyy???

     * @param array<string, string>  &$id                 Dql-Alias => ID-Hash.
     * @param array<string, boolean> &$nonemptyComponents Does this DQL-Alias has at least one non NULL value? 

[Warxcell]

Adjusted a bit test, squashed it in 3 commits (add test, fix bug, add typehints).

I hope it's all good now. :)

[greg0ire]

It looks good to me, although I would squash the failing test and it fix in just one commit: it would not make sense to revert one without also reverting the other. Also, tests should pass on every commit IMO.

[Warxcell]

It looks good to me, although I would squash the failing test and it fix in just one commit: it would not make sense to revert one without also reverting the other. Also, tests should pass on every commit IMO.

My logic behind this is that somebody could provide better implementation of fix and that would required reverting the fix, but not and the test. :)

[beberlei]

Isnt adding types a bc break? Hydrators are a regular extension point of the ORM so we need to be extra careful.

[greg0ire]

@beberlei they all are in an Internal namespace, what about that? Is it not about the BC promise?

[SenseException]

I understand and agree that internal classes can have changes that are usually considered a BC break, but all those other type hints and return types are out of scope for the fix and don't add anything to the bugfix.

[greg0ire]

@Warxcell let's drop that third commit then?

[Warxcell]

@Warxcell let's drop that third commit then?

Done. :(

[greg0ire]

Thanks @Warxcell !