New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single scalar hydrator memory leak on exception #8483
Fix single scalar hydrator memory leak on exception #8483
Conversation
{ | ||
$this | ||
->mockEventManager | ||
->expects(self::at(0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self::at
is deprecated in recent versions of PHPUnit, please avoid it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and rebased, although I do not like the replacement (I did not find any other recommended way). Say if it seems ok to you please. I might replace the the rest of self::at occurrences in this Test class if requested (although it's out of scope of this MR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might replace the the rest of self::at occurrences in this Test class if requested (although it's out of scope of this MR)
It would certainly be appreciated, but it's not at all required.
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. How to do that?
|
7ef0463
to
d684598
Compare
702d96a
to
04646ba
Compare
04646ba
to
2d5207e
Compare
from hydrateAllData() which in turn does not call cleanup()
2d5207e
to
7971a53
Compare
Thanks @olsavmic ! |
Resolves #8482, Closes #7315