[GH-6394] Bugfix: IdentifierFlattener support for association non-object values. #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-object values
…ntifiers for version assignment.
beberlei
force-pushed
the
GH-6394-FlattenIdentifierAssociationBugfix
branch
from
59dadf6
to
b621e77
Compare
SenseException
approved these changes
Dec 15, 2020
|
It is beautify to see this fixed! Thanks @beberlei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6394 Fixes #6393
BasicEntityPersister::updatepasses the wrong representation of identifiers toassignDefaultVersionValue. Instead of grabbing the values fromUnitOfWork::getEntityIdentifierthe methodClassMetadataInfo::getIdentifierValuesmust be used as in all other places where the identify flattener is ultimately used.The difference is that
UnitOfWorkidentifiers contain the scalar values representing an association identifier, butClassMetadataInforepresentation returns the actual entity object./cc @goetas