Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 5 support #7899

Closed
wants to merge 2 commits into from
Closed

Symfony 5 support #7899

wants to merge 2 commits into from

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 14, 2019

This backports #7723 and #7876 to 2.6 for a release in 2.6.5.

@alcaeus alcaeus added this to the 2.6.5 milestone Nov 14, 2019
weaverryan
weaverryan approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andreas! Users will need some version of doctrine/orm that is compatible with Symfony 5. I hope this can be a simple path to that.

@evertharmeling evertharmeling mentioned this pull request Nov 14, 2019
Closed
@Ocramius Ocramius modified the milestones: 2.6.5, 2.7.0 Nov 14, 2019
@Ocramius
Copy link
Member

Should target 2.7

@alcaeus
Copy link
Member Author

alcaeus commented Nov 14, 2019

Should target 2.7

It is in 2.7 already. This is a backport into 2.6 as 2.7 won’t be done in time.

@alcaeus alcaeus modified the milestones: 2.7.0, 2.6.5 Nov 14, 2019
@Ocramius
Copy link
Member

This cannot be merged to 2.6, sorry.

@Ocramius Ocramius closed this Nov 14, 2019
@Ocramius Ocramius self-assigned this Nov 14, 2019
@Ocramius Ocramius removed this from the 2.6.5 milestone Nov 14, 2019
@Ocramius
Copy link
Member

Ocramius commented Nov 14, 2019 •
edited

Also, this has been discussed extensively yesterday, and the maintainers of ORM are pretty much clear on the fact that there may be a rename of current 2.7 to 2.8, while we release this as 2.7. it won't land in 2.6 though, and that's final.

@doctrine doctrine locked as resolved and limited conversation to collaborators Nov 14, 2019
@alcaeus alcaeus deleted the symfony-5-support branch December 12, 2019 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@ostrolucky ostrolucky ostrolucky approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

@Ocramius Ocramius

Labels
Improvement Incomplete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alcaeus @Ocramius @weaverryan @nicolas-grekas @ostrolucky @chalasr